Mercurial > hgsubversion
comparison tests/test_svnwrap.py @ 1457:019c3e194fba
tests: optimise creating repositories and loading dumps
Previously, we'd use svnadmin for creating repositories and loading
dumps. That tends to be a bit slow, as it forks a new process and
loads the Subversion libraries into it. Instead, we extend our
existing Subversion wrappers and load the dumps using the API.
This is a noticable speedup. The only downside is that we rely on
Subversion and Subvertpy to correctly close all file descriptors; an
assumption which hasn't always held in the past.
I ran some benchmarks on my relatively slow Mac with $TMPDIR on a
ramdisk, and they showed a significant change:
I compared ten runs of each with Subvertpy:
min: -18.8% (299.1s -> 243.0s)
median: -20.0% (307.1s -> 245.6s)
...and three runs of each with SWIG:
min: -22.8% (368.7s -> 284.7s)
median: -25.7% (384.4s -> 285.5s)
(Since the timing measures wall clock time, the minimum time is likely
to be the most accurate and useful measurement.)
author | Dan Villiom Podlaski Christiansen <danchr@gmail.com> |
---|---|
date | Tue, 07 Jun 2016 09:15:53 +0200 |
parents | d741f536f23a |
children |
comparison
equal
deleted
inserted
replaced
1456:77da55e0baa4 | 1457:019c3e194fba |
---|---|
9 | 9 |
10 class TestBasicRepoLayout(unittest.TestCase): | 10 class TestBasicRepoLayout(unittest.TestCase): |
11 def setUp(self): | 11 def setUp(self): |
12 self.tmpdir = tempfile.mkdtemp('svnwrap_test') | 12 self.tmpdir = tempfile.mkdtemp('svnwrap_test') |
13 self.repo_path = '%s/testrepo' % self.tmpdir | 13 self.repo_path = '%s/testrepo' % self.tmpdir |
14 subprocess.call(['svnadmin', 'create', self.repo_path, ]) | 14 |
15 inp = open(os.path.join(os.path.dirname(__file__), 'fixtures', | 15 with open(os.path.join(test_util.FIXTURES, |
16 'project_root_at_repo_root.svndump')) | 16 'project_root_at_repo_root.svndump')) as fp: |
17 proc = subprocess.call(['svnadmin', 'load', self.repo_path, ], | 17 svnwrap.create_and_load(self.repo_path, fp) |
18 stdin=inp, | 18 |
19 close_fds=test_util.canCloseFds, | |
20 stdout=subprocess.PIPE, | |
21 stderr=subprocess.STDOUT) | |
22 assert proc == 0 | |
23 self.repo = svnwrap.SubversionRepo(test_util.fileurl(self.repo_path)) | 19 self.repo = svnwrap.SubversionRepo(test_util.fileurl(self.repo_path)) |
24 | 20 |
25 def tearDown(self): | 21 def tearDown(self): |
26 del self.repo | 22 del self.repo |
27 test_util.rmtree(self.tmpdir) | 23 test_util.rmtree(self.tmpdir) |