Mercurial > hgsubversion

annotate tests/fixtures/spaces-in-path.sh @ 1550:67b28d657f62

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
sqliterevmap: break ".hashes()" cycle in a safer way The `fromsvn()` revset implementation could cause weakref error when using sqliterevmap like: File "hgsubversion/util.py", line 357, in <lambda> return subset.filter(lambda r: tonode(r) in hashes) File "hgsubversion/maps.py", line 542, in __contains__ return self.get(key) != None File "hgsubversion/maps.py", line 533, in get for row in self.revmap._query( ReferenceError: weakly-referenced object no longer exists Basically the seemingly harmless assignment could break surprisingly: # dangerous: `hashes` does not have a reference of `meta.revmap` and may # become unavailable after `meta`, `revmap` being released by refcount. hashes = meta.revmap.hashes() The above syntax is nice to support while avoiding cycles is also nice. This patch removes `revmap._hashes` so the revmap no longer owns a reference of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to use weakref for `self.revmap`. This could actually be caught by `comprehensive/test_sqlite_revmap.py`. I was not careful enough verifying the "fromsvn()" patch.
author Jun Wu <quark@fb.com>
date Thu, 21 Dec 2017 17:39:52 -0800
parents a739568f8d48
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
488
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
1 #!/bin/sh
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
2 mkdir temp
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
3 cd temp
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
4 svnadmin create repo
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
5 svn co file://`pwd`/repo wc
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
6 cd wc
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
7 mkdir branches trunk tags
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
8 mkdir tags/versions
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
9 mkdir tags/blah
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
10 svn add *
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
11 svn ci -m 'btt'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
12 cd trunk
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
13 for a in alpha beta gamma delta ; do
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
14 echo $a > $a
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
15 svn add $a
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
16 done
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
17 svn ci -m 'Add files.'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
18
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
19 echo 'foo bar' > 'foo bar'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
20 svn add 'foo bar'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
21 svn ci -m 'Add files.'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
22
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
23 mkdir 'blah blah'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
24 echo 'another file' > 'blah blah/another file'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
25 svn add 'blah blah'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
26 svn ci -m 'Add files.'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
27
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
28 cd ..
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
29 svn up
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
30 svn cp trunk branches/dev_branch
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
31 svn ci -m 'Make a branch'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
32 cd ../..
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
33
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
34 svnadmin dump temp/repo > spaces-in-path.svndump
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
35 echo
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
36 echo 'Complete.'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
37 echo 'You probably want to clean up temp now.'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
38 echo 'Dump in spaces-in-path.svndump'
a739568f8d48 Add a test for URLs that have spaces in them.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
39 exit 0