annotate tools/bisect-find-bad.sh @ 1550:67b28d657f62

sqliterevmap: break ".hashes()" cycle in a safer way The `fromsvn()` revset implementation could cause weakref error when using sqliterevmap like: File "hgsubversion/util.py", line 357, in <lambda> return subset.filter(lambda r: tonode(r) in hashes) File "hgsubversion/maps.py", line 542, in __contains__ return self.get(key) != None File "hgsubversion/maps.py", line 533, in get for row in self.revmap._query( ReferenceError: weakly-referenced object no longer exists Basically the seemingly harmless assignment could break surprisingly: # dangerous: `hashes` does not have a reference of `meta.revmap` and may # become unavailable after `meta`, `revmap` being released by refcount. hashes = meta.revmap.hashes() The above syntax is nice to support while avoiding cycles is also nice. This patch removes `revmap._hashes` so the revmap no longer owns a reference of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to use weakref for `self.revmap`. This could actually be caught by `comprehensive/test_sqlite_revmap.py`. I was not careful enough verifying the "fromsvn()" patch.
author Jun Wu <quark@fb.com>
date Thu, 21 Dec 2017 17:39:52 -0800
parents 11c4c7242a36
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
208
de3807ceea5c Removed verify_* commands and replaced them with a shell script to pass to hg bisect --command.
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
1 #!/bin/bash
213
b1d2ea765516 tools: refactor stuff into common.sh, make verify-all-heads not revert.
Augie Fackler <durin42@gmail.com>
parents: 208
diff changeset
2 . $(dirname $0)/common.sh
396
11c4c7242a36 tools: use new svn verify command instead of svn export incantations
Dirkjan Ochtman <dirkjan@ochtman.nl>
parents: 213
diff changeset
3 hg svn verify
213
b1d2ea765516 tools: refactor stuff into common.sh, make verify-all-heads not revert.
Augie Fackler <durin42@gmail.com>
parents: 208
diff changeset
4 exit $?