Mercurial > hgsubversion
annotate tox.ini @ 1550:67b28d657f62
sqliterevmap: break ".hashes()" cycle in a safer way
The `fromsvn()` revset implementation could cause weakref error when using
sqliterevmap like:
File "hgsubversion/util.py", line 357, in <lambda>
return subset.filter(lambda r: tonode(r) in hashes)
File "hgsubversion/maps.py", line 542, in __contains__
return self.get(key) != None
File "hgsubversion/maps.py", line 533, in get
for row in self.revmap._query(
ReferenceError: weakly-referenced object no longer exists
Basically the seemingly harmless assignment could break surprisingly:
# dangerous: `hashes` does not have a reference of `meta.revmap` and may
# become unavailable after `meta`, `revmap` being released by refcount.
hashes = meta.revmap.hashes()
The above syntax is nice to support while avoiding cycles is also nice.
This patch removes `revmap._hashes` so the revmap no longer owns a reference
of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to
use weakref for `self.revmap`.
This could actually be caught by `comprehensive/test_sqlite_revmap.py`.
I was not careful enough verifying the "fromsvn()" patch.
author | Jun Wu <quark@fb.com> |
---|---|
date | Thu, 21 Dec 2017 17:39:52 -0800 |
parents | 08ea19b989c3 |
children | 0099cf9a9a8b |
rev | line source |
---|---|
1486
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
1 [tox] |
1542 | 2 envlist = hg37,hg38,hg39,hg40,hg41,hg42,hg43,hg44 |
1486
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
3 |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
4 [testenv] |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
5 deps= |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
6 nose |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
7 hg37: Mercurial==3.7.3 |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
8 hg38: Mercurial==3.8.3 |
1499
60690af283e5
tox: add more hg versions for testing
Augie Fackler <raf@durin42.com>
parents:
1486
diff
changeset
|
9 hg39: Mercurial==3.8.3 |
60690af283e5
tox: add more hg versions for testing
Augie Fackler <raf@durin42.com>
parents:
1486
diff
changeset
|
10 hg40: Mercurial==4.0.2 |
1523
83b28c179d19
tox: update hg version list
Augie Fackler <raf@durin42.com>
parents:
1500
diff
changeset
|
11 hg41: Mercurial==4.1.3 |
83b28c179d19
tox: update hg version list
Augie Fackler <raf@durin42.com>
parents:
1500
diff
changeset
|
12 hg42: Mercurial==4.2.2 |
83b28c179d19
tox: update hg version list
Augie Fackler <raf@durin42.com>
parents:
1500
diff
changeset
|
13 hg43: Mercurial==4.3.1 |
1542 | 14 hg44: Mercurial==4.4 |
1486
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
15 subvertpy |
be8f446f94e5
testing: add tox config to easily run tests against many hg versions
Augie Fackler <raf@durin42.com>
parents:
diff
changeset
|
16 commands=nosetests {posargs} |