annotate .hgtags @ 717:ae5968ffe6fe

svnwrap: fix handling of quotable URLs (fixes #197, refs #132) The way hgsubversion handles URLs that may or may not be quoted is somewhat fragile. As part of fixing issue 132 in 925ff8c5989c, the path component of URLs was always quoted. The URL has been attempted encoded since the initial check-in. The fix from 925ff8c5989c was incomplete; reverting it allows us to clone a URL with a '~' in it.[1] Encoding the URL as UTF-8 seldom works as expected, as the default string encoding is ASCII, causing Python to be unable to decode any URL containing an 8-bit character. The core problem here is that we don't know whether the URL specified by the user is quoted or not. Rather than trying to deal with this ourselves, we pass the problem on to Subversion. Then, we obtain the URL from the RA instance, where it is always quoted. (It's worth noting that the editor interface, on the other hand, always deals with unquoted paths...) Thus, the following invariants should apply to SubversionRepo attributes: - svn_url and root will always be quoted. - subdir will always be unquoted. Tests are added that verify that it won't affect the conversion whether a URL is specified in quoted or unquoted form. Furthermore, a test fixture for this is added *twice*, so that we can thoroughly test both quoted and unquoted URLs. I'm not adding a test dedicated to tildes in URLs; it doesn't seem necessary. [1] Such as <https://svn.kenai.com/svn/winsw~subversion>.
author Dan Villiom Podlaski Christiansen <danchr@gmail.com>
date Mon, 04 Oct 2010 21:00:36 -0500
parents 493023041e74
children 2ddb95cd36dd
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
554
d2d5c09b33d0 Added tag 1.0 for changeset 97f2079e3778
Augie Fackler <durin42@gmail.com>
parents:
diff changeset
1 97f2079e3778511944ffb6a662520580650a3993 1.0
564
7bd457ec4e5e Added tag 1.0.1 for changeset 09c016174e33
Augie Fackler <durin42@gmail.com>
parents: 554
diff changeset
2 09c016174e332eceda015d3f43d96d7e0228acf3 1.0.1
592
b4c3afc95420 Added tag 1.1 for changeset 4359ddd73b00
Augie Fackler <durin42@gmail.com>
parents: 564
diff changeset
3 4359ddd73b009fbb356c52ea5d99cba25222ee7a 1.1
627
faba8e636960 Added tag 1.1.1 for changeset 8e621dbb82d4
Augie Fackler <durin42@gmail.com>
parents: 592
diff changeset
4 8e621dbb82d4363a85317638ad237e2817c56347 1.1.1
631
493023041e74 Added tag 1.1.2 for changeset 093ae2915b45
Augie Fackler <durin42@gmail.com>
parents: 627
diff changeset
5 093ae2915b452539b44390ee4ea14987484e1eee 1.1.2