annotate tests/comprehensive/test_obsstore_on.py @ 1516:fbc22592f4fa

push: lock repo before calling createmarkers Previously, when devel.all-warnings is set to True, hg subversion will crash when pushing with the error: ProgrammingError: transaction requires locking Tracking that down, that is because "createmarkers" was called without locking. A comprehensive test was added to run test_push_command with obsstore turned on to cover the code paths.
author Jun Wu <quark@fb.com>
date Mon, 07 Aug 2017 18:12:16 -0700
parents
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1516
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
1 import os
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
2 import sys
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
3
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
4 # wrapped in a try/except because of weirdness in how
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
5 # run.py works as compared to nose.
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
6 try:
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
7 import test_util
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
8 except ImportError:
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
9 sys.path.insert(0, os.path.dirname(os.path.dirname(__file__)))
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
10 import test_util
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
11
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
12 import test_push_command
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
13
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
14
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
15 class ObsstoreOnMixIn(object):
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
16 # do not double the test size by being wrapped again
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
17 obsolete_mode_tests = False
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
18 stupid_mode_tests = False
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
19
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
20 def setUp(self):
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
21 super(ObsstoreOnMixIn, self).setUp()
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
22 hgrcpath = os.environ.get('HGRCPATH')
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
23 assert hgrcpath
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
24 with open(hgrcpath, 'a') as f:
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
25 f.write('\n[experimental]\nevolution=createmarkers\n')
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
26
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
27 def shortDescription(self):
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
28 text = super(ObsstoreOnMixIn, self).shortDescription()
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
29 if text:
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
30 text += ' (obsstore on)'
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
31 return text
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
32
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
33
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
34 def buildtestclass(cls):
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
35 name = 'ObsstoreOn%s' % cls.__name__
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
36 newcls = type(name, (ObsstoreOnMixIn, cls,), {})
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
37 globals()[name] = newcls
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
38
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
39
fbc22592f4fa push: lock repo before calling createmarkers
Jun Wu <quark@fb.com>
parents:
diff changeset
40 buildtestclass(test_push_command.PushTests)