editor: fix edge case with in memory file-store size limit There are a few cases where we will set a single file into to the editor's FileStore object more than once. Notably, for copied and then modified files, we will set it at least twice. Three times if editing fails (which it can for symlinks). If we pass the in-memory storage limit in between the first (or second if editing fails) time we set the file and the last time we set the file, we will write the data to the in memory store the first time and the file store the last time. We didn't remove it form the in-memory store though, and we always prefer reading from the in-memory store. This means we can sometimes end up with the wrong version of a file. This is fairly unlikely to happen in normal use since you need to hit the memory limit between two writes to the store for the same file. We only write a file multiple times if a) the file (and not one of it's parent directories) is copied and then modified or b) editing fails. From what I can tell, it's only common for editing to fail for symlinks, and they ten to be relatively small data that is unlikely to push over the limit. Finally, the default limit is 100MB which I would expect to be most often either well over (source code) or well under (binaries or automated changes) the size of the changes files in a single commit. The easiest way to reproduce this is to set the in-memory cache size to 0 and then commit a copied and modified symlink. The empty-string version from the failed editing will be the one that persists. I happened to stumble upon this while trying (and failing) to test a bug-fix for a related bug with identical symptoms (empty simlink). I have seen this in the wild, once, but couldn't reproduce it at the time. The repo in question is quite large and quite active, so I am quite confident in my estimation that this is a real, but very rare, problem. The test changes attached to this was mneant to test a related bug, but turned out not to actually cover the bug in question. They did trigger this bug though, and are worthwhile to test, so I kept them.

SVN-fs-dump-format-version: 2

UUID: 00000000-0000-0000-0000-000000000000

Revision-number: 0
Prop-content-length: 56
Content-length: 56

K 8
svn:date
V 27
2010-11-30T15:10:25.898546Z
PROPS-END

Revision-number: 1
Prop-content-length: 100
Content-length: 100

K 10
svn:author
V 6
danchr
K 8
svn:date
V 27
2010-11-30T15:16:01.077550Z
K 7
svn:log
V 0

PROPS-END

Node-path: another-regular-file
Node-kind: file
Node-action: add
Prop-content-length: 10
Text-content-length: 0
Text-content-md5: d41d8cd98f00b204e9800998ecf8427e
Text-content-sha1: da39a3ee5e6b4b0d3255bfef95601890afd80709
Content-length: 10

PROPS-END


Node-path: executable-file
Node-kind: file
Node-action: add
Prop-content-length: 10
Text-content-length: 11
Text-content-md5: 01839ba8c81c3b2c7486607e0c683e62
Text-content-sha1: 5e70f8a25fe8ad4ad971bfd3388c258b019268d4
Content-length: 21

PROPS-END
Executable


Node-path: missing-file
Node-kind: file
Node-action: add
Prop-content-length: 10
Text-content-length: 0
Text-content-md5: d41d8cd98f00b204e9800998ecf8427e
Text-content-sha1: da39a3ee5e6b4b0d3255bfef95601890afd80709
Content-length: 10

PROPS-END


Node-path: regular-file
Node-kind: file
Node-action: add
Prop-content-length: 33
Text-content-length: 18
Text-content-md5: adf66a0cec83e25644c63f3c3007ae7c
Text-content-sha1: 047e6e482d0c9cb812f89d18a9f07a43caab76bb
Content-length: 51

K 11
svn:special
V 1
*
PROPS-END
link Bad contents.

Node-path: symlink
Node-kind: file
Node-action: add
Prop-content-length: 10
Text-content-length: 1
Text-content-md5: 7fc56270e7a70fa81a5935b72eacbe29
Text-content-sha1: 6dcd4ce23d88e2ee9568ba546c007c63d9131c1b
Content-length: 11

PROPS-END
A