Mercurial > hgsubversion
view tests/comprehensive/test_sqlite_revmap.py @ 1539:0ebcc5bbf692
tests: when making a `memctx`, make sure to use a single repo instance
The way self.repo is dynamic produces bad lock behavior because the
`context.memctx` ends up with a different instance than self in
`localrepo.commitctx`, which means the callbacks in the `memctx` get
an unlocked repo instance. This causes lock warning failures. When
it's not a code freeze for core, we should probably:
* Make lock failures hard, not just warnings
* Stop holding a repo reference in memctx, or otherwise check it's the same
instance as `self` during `localrepo.commitctx`
That's my best guess based on the (very hard to debug) test failures here.
author | Augie Fackler <raf@durin42.com> |
---|---|
date | Sat, 28 Oct 2017 21:34:52 -0400 |
parents | f21605bcda24 |
children |
line wrap: on
line source
import os import unittest import sys # wrapped in a try/except because of weirdness in how # run.py works as compared to nose. try: import test_util except ImportError: sys.path.insert(0, os.path.dirname(os.path.dirname(__file__))) import test_util # interesting and fast tests import test_fetch_mappings import test_fetch_renames import test_pull import test_template_keywords import test_utility_commands # comprehensive tests try: import test_custom_layout except ImportError: sys.path.insert(0, os.path.dirname(__file__)) import test_custom_layout import test_rebuildmeta import test_updatemeta from hgsubversion import svnmeta, maps class SqliteRevMapMixIn(object): # do not double the test size by being wrapped again obsolete_mode_tests = False stupid_mode_tests = False def setUp(self): assert svnmeta.SVNMeta._defaultrevmapclass is maps.RevMap svnmeta.SVNMeta._defaultrevmapclass = maps.SqliteRevMap super(SqliteRevMapMixIn, self).setUp() def tearDown(self): assert svnmeta.SVNMeta._defaultrevmapclass is maps.SqliteRevMap svnmeta.SVNMeta._defaultrevmapclass = maps.RevMap super(SqliteRevMapMixIn, self).tearDown() def shortDescription(self): text = super(SqliteRevMapMixIn, self).shortDescription() if text: text += ' (sqlite revmap)' return text def buildtestclass(cls, selector=None): name = 'SqliteRevMap%s' % cls.__name__ newcls = type(name, (SqliteRevMapMixIn, cls,), {}) # remove test cases not selected by selector if selector: for name in dir(newcls): if name.startswith('test_') and not selector(name[5:]): setattr(newcls, name, None) globals()[name] = newcls def svndumpselector(name): return name in ['branch_rename_to_trunk', 'tag_name_same_as_branch'] buildtestclass(test_fetch_mappings.MapTests) buildtestclass(test_fetch_renames.TestFetchRenames) buildtestclass(test_pull.TestPull) buildtestclass(test_template_keywords.TestLogKeywords) buildtestclass(test_utility_commands.UtilityTests) buildtestclass(test_rebuildmeta.RebuildMetaTests, svndumpselector) buildtestclass(test_updatemeta.UpdateMetaTests, svndumpselector)