Mercurial > hgsubversion
view tests/test_fetch_dir_removal.py @ 1539:0ebcc5bbf692
tests: when making a `memctx`, make sure to use a single repo instance
The way self.repo is dynamic produces bad lock behavior because the
`context.memctx` ends up with a different instance than self in
`localrepo.commitctx`, which means the callbacks in the `memctx` get
an unlocked repo instance. This causes lock warning failures. When
it's not a code freeze for core, we should probably:
* Make lock failures hard, not just warnings
* Stop holding a repo reference in memctx, or otherwise check it's the same
instance as `self` during `localrepo.commitctx`
That's my best guess based on the (very hard to debug) test failures here.
author | Augie Fackler <raf@durin42.com> |
---|---|
date | Sat, 28 Oct 2017 21:34:52 -0400 |
parents | 8c7dae2e0f54 |
children |
line wrap: on
line source
import test_util import sys import unittest class TestFetchDirectoryRemoval(test_util.TestBase): stupid_mode_tests = True def test_removal(self): repo = self._load_fixture_and_fetch('dir_removal.svndump', layout='single', subdir='dir1') self.assertEqual(sorted(repo['tip'].manifest().keys()), ['1.txt', 'dir2/2.txt']) extra = repo['tip'].extra().copy() extra.pop('convert_revision', None) self.assertEqual(extra, {'branch': 'default'})