clone: pass on the repository instance rather than the string given Previously, cloning a Mercurial repository that required authentication would prompt for authentication twice. This is because hgclonewrapper() first created a repository instance, but didn't pass it on. hg.close() would then create another instance, and since Mercurial doesn't cache authentication credentials across instances, this would cause a second credential prompt. This change could have unfortunate side effects in case of other extensions wanting to modify the source passed to clone. This seems like a somewhat unlikely scenario. I'll think about a possible way to avoid all this hackery...

#!/bin/sh
mkdir temp || exit 1
cd temp
svnadmin create repo
svn co file://`pwd`/repo wc
pushd wc
mkdir -p project/trunk
svn add project
svn ci -m 'trunk'
cd project/trunk
echo a > a
mkdir narf
svn add a narf
svn ci -m 'file and empty dir'
popd
svnadmin dump repo > ../empty_dir_in_trunk_not_repo_root.svndump
echo 'dump in empty_dir_in_trunk_not_repo_root.svndump'
echo 'you can probably delete temp now'