sqliterevmap: break ".hashes()" cycle in a safer way The `fromsvn()` revset implementation could cause weakref error when using sqliterevmap like: File "hgsubversion/util.py", line 357, in <lambda> return subset.filter(lambda r: tonode(r) in hashes) File "hgsubversion/maps.py", line 542, in __contains__ return self.get(key) != None File "hgsubversion/maps.py", line 533, in get for row in self.revmap._query( ReferenceError: weakly-referenced object no longer exists Basically the seemingly harmless assignment could break surprisingly: # dangerous: `hashes` does not have a reference of `meta.revmap` and may # become unavailable after `meta`, `revmap` being released by refcount. hashes = meta.revmap.hashes() The above syntax is nice to support while avoiding cycles is also nice. This patch removes `revmap._hashes` so the revmap no longer owns a reference of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to use weakref for `self.revmap`. This could actually be caught by `comprehensive/test_sqlite_revmap.py`. I was not careful enough verifying the "fromsvn()" patch.

#!/bin/sh
#
# Generate executebit.svndump
#

mkdir temp
cd temp

mkdir project-orig
cd project-orig
mkdir trunk
cd ..

svnadmin create testrepo
svnurl=file://`pwd`/testrepo
svn import project-orig $svnurl -m "init project"

svn co $svnurl project
cd project/trunk
echo text > text1
echo text > text2
touch empty1
touch empty2
python -c "file('binary1', 'wb').write('a\x00b')"
python -c "file('binary2', 'wb').write('a\x00b')"
svn add text1 text2 binary1 binary2 empty1 empty2
svn propset svn:mime-type application/octet-stream binary1 binary2
svn propset svn:executable yes binary1 text1 empty1
svn ci -m init
# switch exec properties
svn propdel svn:executable binary1 text1 empty1
svn propset svn:executable yes binary2 text2 empty2
svn ci -m changeexec
cd ../..

svnadmin dump testrepo > ../executebit.svndump