sqliterevmap: break ".hashes()" cycle in a safer way The `fromsvn()` revset implementation could cause weakref error when using sqliterevmap like: File "hgsubversion/util.py", line 357, in <lambda> return subset.filter(lambda r: tonode(r) in hashes) File "hgsubversion/maps.py", line 542, in __contains__ return self.get(key) != None File "hgsubversion/maps.py", line 533, in get for row in self.revmap._query( ReferenceError: weakly-referenced object no longer exists Basically the seemingly harmless assignment could break surprisingly: # dangerous: `hashes` does not have a reference of `meta.revmap` and may # become unavailable after `meta`, `revmap` being released by refcount. hashes = meta.revmap.hashes() The above syntax is nice to support while avoiding cycles is also nice. This patch removes `revmap._hashes` so the revmap no longer owns a reference of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to use weakref for `self.revmap`. This could actually be caught by `comprehensive/test_sqlite_revmap.py`. I was not careful enough verifying the "fromsvn()" patch.

#!/bin/bash
#-*- coding: utf-8 -*-
#
# Generate invalid_utf8.svndump
#

#check svnadmin version, must be >= 1.7
SVNVERSION=$(svnadmin --version | head -n 1 | cut -d \  -f 3)
if [[ "$SVNVERSION" < '1.7' ]] ; then
    echo "You MUST have svn 1.7 or above to use this script"
    exit 1
fi

set -x

TMPDIR=$(mktemp -d)
WD=$(pwd)

cd $TMPDIR

svnadmin create failrepo
svn co file://$PWD/failrepo fail
(
   cd fail
   touch A
   svn add A
   svn ci -m blabargrod
)
svnadmin --pre-1.6-compatible create invalid_utf8
svnadmin dump failrepo | \
    sed "s/blabargrod/$(echo blåbærgrød | iconv -f utf-8 -t latin1)/g" | \
    svnadmin load --bypass-prop-validation invalid_utf8

tar cz -C invalid_utf8 -f "$WD"/invalid_utf8.tar.gz .