Mercurial > hgsubversion
view tests/fixtures/non_ascii_path_1.svndump @ 1550:67b28d657f62
sqliterevmap: break ".hashes()" cycle in a safer way
The `fromsvn()` revset implementation could cause weakref error when using
sqliterevmap like:
File "hgsubversion/util.py", line 357, in <lambda>
return subset.filter(lambda r: tonode(r) in hashes)
File "hgsubversion/maps.py", line 542, in __contains__
return self.get(key) != None
File "hgsubversion/maps.py", line 533, in get
for row in self.revmap._query(
ReferenceError: weakly-referenced object no longer exists
Basically the seemingly harmless assignment could break surprisingly:
# dangerous: `hashes` does not have a reference of `meta.revmap` and may
# become unavailable after `meta`, `revmap` being released by refcount.
hashes = meta.revmap.hashes()
The above syntax is nice to support while avoiding cycles is also nice.
This patch removes `revmap._hashes` so the revmap no longer owns a reference
of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to
use weakref for `self.revmap`.
This could actually be caught by `comprehensive/test_sqlite_revmap.py`.
I was not careful enough verifying the "fromsvn()" patch.
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Thu, 21 Dec 2017 17:39:52 -0800 |
| parents | ae5968ffe6fe |
| children |
line wrap: on
line source
SVN-fs-dump-format-version: 2 UUID: a7b92ce5-70a8-4e75-99da-c3ca360ae490 Revision-number: 0 Prop-content-length: 56 Content-length: 56 K 8 svn:date V 27 2010-08-16T13:08:38.494252Z PROPS-END Revision-number: 1 Prop-content-length: 121 Content-length: 121 K 7 svn:log V 20 Create project bøb. K 10 svn:author V 6 danchr K 8 svn:date V 27 2010-08-16T13:10:12.395716Z PROPS-END Node-path: bøb Node-kind: dir Node-action: add Prop-content-length: 10 Content-length: 10 PROPS-END Node-path: bøb/branches Node-kind: dir Node-action: add Prop-content-length: 10 Content-length: 10 PROPS-END Node-path: bøb/tags Node-kind: dir Node-action: add Prop-content-length: 10 Content-length: 10 PROPS-END Node-path: bøb/trunk Node-kind: dir Node-action: add Prop-content-length: 10 Content-length: 10 PROPS-END Node-path: bøb/trunk/A Node-kind: file Node-action: add Prop-content-length: 10 Text-content-length: 1 Text-content-md5: 68b329da9893e34099c7d8ad5cb9c940 Text-content-sha1: adc83b19e793491b1c6ea0fd8b46cd9f32e592fc Content-length: 11 PROPS-END Revision-number: 2 Prop-content-length: 112 Content-length: 112 K 7 svn:log V 11 Add a file. K 10 svn:author V 6 danchr K 8 svn:date V 27 2010-08-16T14:04:00.624391Z PROPS-END Node-path: bøb/trunk/B Node-kind: file Node-action: add Prop-content-length: 10 Text-content-length: 1 Text-content-md5: 68b329da9893e34099c7d8ad5cb9c940 Text-content-sha1: adc83b19e793491b1c6ea0fd8b46cd9f32e592fc Content-length: 11 PROPS-END