sqliterevmap: break ".hashes()" cycle in a safer way The `fromsvn()` revset implementation could cause weakref error when using sqliterevmap like: File "hgsubversion/util.py", line 357, in <lambda> return subset.filter(lambda r: tonode(r) in hashes) File "hgsubversion/maps.py", line 542, in __contains__ return self.get(key) != None File "hgsubversion/maps.py", line 533, in get for row in self.revmap._query( ReferenceError: weakly-referenced object no longer exists Basically the seemingly harmless assignment could break surprisingly: # dangerous: `hashes` does not have a reference of `meta.revmap` and may # become unavailable after `meta`, `revmap` being released by refcount. hashes = meta.revmap.hashes() The above syntax is nice to support while avoiding cycles is also nice. This patch removes `revmap._hashes` so the revmap no longer owns a reference of a `ReverseRevMap` object so the `ReverseRevMap` object no longer needs to use weakref for `self.revmap`. This could actually be caught by `comprehensive/test_sqlite_revmap.py`. I was not careful enough verifying the "fromsvn()" patch.

#!/bin/sh

mkdir temp
cd temp
svnadmin create repo
svn co file://`pwd`/repo wc
export REPO=file://`pwd`/repo
cd wc
mkdir branches trunk tags
svn add *
svn ci -m 'Empty dirs.'

echo 'file: alpha' > trunk/alpha
svn add trunk/alpha
svn ci -m 'Add alpha'
svn up

echo 'Data of beta' > trunk/beta
svn add trunk/beta
svn ci -m 'Add beta'
svn up
cd ..

svn cp -m 'tagging r3' $REPO/trunk@3 $REPO/tags/tag_r3
svn cp -m 'tag from a tag' $REPO/tags/tag_r3 $REPO/tags/copied_tag
svn mv -m 'rename a tag' $REPO/tags/copied_tag $REPO/tags/other_tag_r3
cd ..
svnadmin dump temp/repo > rename_tag_test.svndump
echo
echo 'Complete.'
echo 'You probably want to clean up temp now.'
echo 'Dump in renametagdir.svndump'
exit 0