# HG changeset patch # User Sean Farley # Date 1401744714 18000 # Node ID 1414cdafa7af509a2fd98dfaeac0894b80ea7d45 # Parent 87837284917582689a552de2a7bc4dede3dbfe75 svnmeta: explicitly test for None There was a slight error in the way we were checking the value of 'c' via 'if c'. If the type of 'c' is a bool then this could incorrectly be false. Instead, we check for None explicitly. Nothing in production should have been affected by this yet since this was only a problem with patches not yet released. diff --git a/hgsubversion/svnmeta.py b/hgsubversion/svnmeta.py --- a/hgsubversion/svnmeta.py +++ b/hgsubversion/svnmeta.py @@ -103,7 +103,7 @@ class SVNMeta(object): val = util.load(f, default=default) # prefer the non-default, and the one sent from command-line - if c and c != val and c != default: + if c is not None and c != val and c != default: val = c # set the value as the one from disk (or default if not found)