# HG changeset patch # User Jun Wu # Date 1464045110 -3600 # Node ID a794cbc174a9717efbee2c3a852b717e6f4d34d2 # Parent 52749d8aba99e80f1fcaa60c5282dc8c76a2449e maps: document RevMap.batchset will not update internal state Judging from the name, RevMap.batchset seems to be equivalent to multiple "__setitem__"s. But it neither calls dict.__setitem__ nor updates "_hashes". Update the docstring to make it clear the in-memory state is not updated. diff --git a/hgsubversion/maps.py b/hgsubversion/maps.py --- a/hgsubversion/maps.py +++ b/hgsubversion/maps.py @@ -384,8 +384,8 @@ class RevMap(dict): items is an array of (rev num, branch, binary hash) - For performance reason, meta.lastpulled and meta.firstpulled - are not updated. + For performance reason, internal in-memory state is not updated. + To get an up-to-date RevMap, reconstruct the object. ''' f = open(self.meta.revmap_file, 'a') f.write(''.join('%s %s %s\n' % (revnum, hex(binhash), br or '')