changeset 604:1290ab9def8f

pull: fix passing credentials in URL. Previously, the parsed URL - with credentials removed - was used for instantiating a new svnremoterepo instance. One option for fixing this is using the unparsed URL for this instantiation. An even better option, however, is to simply reuse the instance passed to the function as `source'.
author Dan Villiom Podlaski Christiansen <danchr@gmail.com>
date Thu, 01 Apr 2010 16:06:01 +0200
parents 24c73f35f3cf
children b72850177e5c
files hgsubversion/wrappers.py
diffstat 1 files changed, 1 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/hgsubversion/wrappers.py
+++ b/hgsubversion/wrappers.py
@@ -222,8 +222,7 @@ def pull(repo, source, heads=[], force=F
     if not have_replay:
         repo.ui.note('fetching stupidly...\n')
 
-    # TODO: do credentials specified in the URL still work?
-    svn = svnrepo.svnremoterepo(repo.ui, svn_url).svn
+    svn = source.svn
     meta = repo.svnmeta(svn.uuid, svn.subdir)
 
     layout = repo.ui.config('hgsubversion', 'layout', 'auto')